On Tue, Jan 03, 2017 at 12:55:49PM +0100, Gary Bisson wrote:
> Hi Shawn,
>
> On Tue, Jan 03, 2017 at 07:43:17PM +0800, Shawn Guo wrote:
> > On Tue, Jan 03, 2017 at 12:22:46PM +0100, Gary Bisson wrote:
> > > This patch fixes the following error:
> > > sgtl5000 0-000a: Error reading chip id -6
> > > imx-sgtl5000 sound: ASoC: CODEC DAI sgtl5000 not registered
> > > imx-sgtl5000 sound: snd_soc_register_card failed (-517)
> > >
> > > The problem was that the pinctrl group was linked to the sound driver
> > > instead of the codec node. Since the codec is probed first, the sys_mclk
> > > was missing and it would therefore fail to initialize.
> > >
> > > Signed-off-by: Gary Bisson <gary.bisson@xxxxxxxxxxxxxxxxxxx>
> >
> > Should we have it go as a fix for v4.10-rc cycles? In that case, please
> > add a Fixes: tag. Also, do we need to apply it for stable kernel?
>
> Sure it'd be great if it could be in v4.10.
> Fixes: b32e700256bc ("ARM: dts: imx: add Boundary Devices Nitrogen6_Max board")
>
> As for stable kernel, I guess it wouldn't hurt but it's not mandatory in
> my opinion.
I wouldn't bother stable kernel then.
>
> Do you want me to re-send with the Fixes line?
No. I can add the Fixes tag.
> What about the SOM2
> patch, should it include a Fixes line although it works thanks to
> U-Boot?
Yes, please give me the Fixes tag, and I will send both patches for
v4.10 inclusion.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
