On Saturday, December 31, 2016 10:48:39 AM CET Florian Fainelli wrote: > > On 12/29/2016 11:37 PM, Greentime Hu wrote: > > Signed-off-by: Greentime Hu <green.hu@xxxxxxxxx> > > This is not enough, you need to add a Device Tree binding document under > Documentation/devicetree/bindings/net/ which documents this compatible > string, as well as additional properties that may be required to > describe this hardware block. We already have Documentation/devicetree/bindings/net/moxa,moxart-mac.txt for the same hardware (though used by a different driver). I'd suggest renaming that one to a more generic file name and adding the new compatible string there. Aside from that, every patch should also have a changelog comment. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
