On Thu, Dec 29, 2016 at 07:22:12PM +0100, Alexander Koch wrote: > On 12/26/2016 11:47 AM, Guenter Roeck wrote: > > On 12/23/2016 02:12 PM, Alexander Koch wrote: > >> Replace sysfs symbolic file permissions, e.g. 'S_IRUGO', by octal > >> permissions. This fixes checkpatch.pl warnings. > >> > >> Signed-off-by: Alexander Koch <mail@xxxxxxxxxxxxxxxxx> > > > > Please do not bother with those warnings and ignore checkpatch. > > We are in the process of doing an automated conversion. > > Okay, so I shall create v3 of the patchset, without these changes. I've > found a typo in the 4th patch so I thought about going v3 anyways. > > I've tested operation modes 1-3 on real hardware today and found no > issues so far, so I hope v3 will have good chances of getting accepted. > Pretty much. One request, though: If there is no configuration data from DT, I would like the driver to read the mode from the chip - if for nothing else, this will let me test all modes, but it also supports the case where the chip is configured by BIOS/ROMMON. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
