Hi Krzysztof, > > #define EXYNOS5420_PIN_DRV_LV3 2 > > #define EXYNOS5420_PIN_DRV_LV4 3 > > > > +/* Drive strengths for Exynos5433 */ > > +#define EXYNOS5433_PIN_DRV_LV1 0 > > +#define EXYNOS5433_PIN_DRV_LV2 1 > > +#define EXYNOS5433_PIN_DRV_LV3 2 > > +#define EXYNOS5433_PIN_DRV_LV4 3 > > Same values as existing. No need to re-define these. Yes, I was in doubt when I prepared this patch as on one hand it didn't look right to use EXYNOS5420_* for exynos5433, on the other hand it didn't look right to duplicate the macros. In anycase this values need to be fixed as Chanwoo wrote in the other mail. Thanks, Andi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html