> On 28 Dec 2016, at 7:12 AM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > > On 12/26/2016 05:59 PM, Jaedon Shin wrote: >> Adds SPI device nodes to BCM7xxx MIPS based SoCs. >> >> Signed-off-by: Jaedon Shin <jaedon.shin@xxxxxxxxx> >> --- >> arch/mips/boot/dts/brcm/bcm7125.dtsi | 55 +++++++++++++++++++++++++++++-- >> arch/mips/boot/dts/brcm/bcm7346.dtsi | 49 +++++++++++++++++++++++++++ >> arch/mips/boot/dts/brcm/bcm7358.dtsi | 49 +++++++++++++++++++++++++++ >> arch/mips/boot/dts/brcm/bcm7360.dtsi | 49 +++++++++++++++++++++++++++ >> arch/mips/boot/dts/brcm/bcm7362.dtsi | 49 +++++++++++++++++++++++++++ >> arch/mips/boot/dts/brcm/bcm7420.dtsi | 55 +++++++++++++++++++++++++++++-- >> arch/mips/boot/dts/brcm/bcm7425.dtsi | 49 +++++++++++++++++++++++++++ >> arch/mips/boot/dts/brcm/bcm7435.dtsi | 49 +++++++++++++++++++++++++++ >> arch/mips/boot/dts/brcm/bcm97125cbmb.dts | 4 +++ >> arch/mips/boot/dts/brcm/bcm97346dbsmb.dts | 4 +++ >> arch/mips/boot/dts/brcm/bcm97358svmb.dts | 36 ++++++++++++++++++++ >> arch/mips/boot/dts/brcm/bcm97360svmb.dts | 36 ++++++++++++++++++++ >> arch/mips/boot/dts/brcm/bcm97362svmb.dts | 4 +++ >> arch/mips/boot/dts/brcm/bcm97420c.dts | 4 +++ >> arch/mips/boot/dts/brcm/bcm97425svmb.dts | 36 ++++++++++++++++++++ >> arch/mips/boot/dts/brcm/bcm97435svmb.dts | 4 +++ >> 16 files changed, 526 insertions(+), 6 deletions(-) >> >> diff --git a/arch/mips/boot/dts/brcm/bcm7125.dtsi b/arch/mips/boot/dts/brcm/bcm7125.dtsi >> index bbd00f65ce39..c1e19e57f64a 100644 >> --- a/arch/mips/boot/dts/brcm/bcm7125.dtsi >> +++ b/arch/mips/boot/dts/brcm/bcm7125.dtsi >> @@ -46,6 +46,12 @@ >> #clock-cells = <0>; >> clock-frequency = <27000000>; >> }; >> + >> + spi_clk: spi_clk { >> + compatible = "fixed-clock"; >> + #clock-cells = <0>; >> + clock-frequency = <27000000>; >> + }; > > Nit, this should actually be upg_clk, since this is the clock that the > SPI controller uses, and it is a fixed-clock with a 27Mhz frequency. > > Other than that, the rest looks good to me, thanks! > -- > Florian I will change the qspi uses upg_clk in v2. Thanks, Jaedon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html