Dear Sebastian,
Thanks for your feedback!
On Thu, Dec 22, 2016 at 11:49 PM, Sebastian Reichel <sre@xxxxxxxxxx> wrote:
>
> I'm talking about the special case, where it also sends only a
> single byte:
>
>> + /* send the power-off command to PIC */
>> + if(cfg->cmd[0][0] == 1 && cfg->cmd[1][0] == 0) {
>> + /* if it's simply one-byte command, send it directly */
>> + writel(cfg->cmd[0][1], UART1_REG(TX));
>> + }
>
> The configuration is different, but
>
> a) probably it can just use the config from the qnap driver, since
> it just sends a single byte.
> b) making the 4 config registers configurable in the qnap driver does
> not add much complexity.
>
> So this case should be removed from the linkstation-reset driver. If
> any board needs it, it should use the qnap-poweroff driver instead.
Yes, if other board need sending one-byte command to UART1, it should
make use of qnap-poweroff driver.
However, one model of Linkstation need such kind of command, I would
like to add it in linkstation-reset driver.
Currently, there's no such usage, so if you don't like the redundant
code which sending one-byte command, I can remove in my next patch
series.
Merry Xmas and happy new year!
Cheers,
--
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
