On 12/22, Zoran Markovic wrote: > +static struct clk_branch ebi2_clk = { > + .hwcg_reg = 0x2664, > + .hwcg_bit = 6, > + .halt_reg = 0x2fcc, > + .halt_bit = 23, > + .clkr = { > + .enable_reg = 0x2664, > + .enable_mask = BIT(6)|BIT(4), Some spaces here around | please. > + .hw.init = &(struct clk_init_data){ > + .name = "ebi2_clk", > + .ops = &clk_branch_ops, > + }, > + }, > +}; > + > +static struct clk_branch ebi2_aon_clk = { > + .halt_reg = 0x2fcc, > + .halt_bit = 23, > + .clkr = { > + .enable_reg = 0x2664, > + .enable_mask = BIT(8), > + .hw.init = &(struct clk_init_data){ > + .name = "ebi2_always_on_clk", Maybe just ebi2_aon_clk to keep things simple. > + .ops = &clk_branch_ops, > + }, > + }, > +}; > + > static struct clk_hw *gcc_mdm9615_hws[] = { > &cxo.hw, > }; > diff --git a/include/dt-bindings/clock/qcom,gcc-mdm9615.h b/include/dt-bindings/clock/qcom,gcc-mdm9615.h > index 9ab2c40..57cdca6 100644 > --- a/include/dt-bindings/clock/qcom,gcc-mdm9615.h > +++ b/include/dt-bindings/clock/qcom,gcc-mdm9615.h > @@ -323,5 +323,8 @@ > #define CE3_H_CLK 305 > #define USB_HS1_SYSTEM_CLK_SRC 306 > #define USB_HS1_SYSTEM_CLK 307 > +#define EBI2_CLK 309 Why jump from 307 to 309? > +#define EBI2_AON_CLK 310 > + -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html