On Tue, Dec 20, 2016 at 03:34:10PM +0100, Code Kipper wrote: > On 20 December 2016 at 15:07, Maxime Ripard > <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > > Hi, > > > > On Tue, Dec 20, 2016 at 11:40:37AM +0100, codekipper@xxxxxxxxx wrote: > >> From: Marcus Cooper <codekipper@xxxxxxxxx> > >> > >> Add the SPDIF transceiver controller block to the A31 dtsi. > >> > >> Signed-off-by: Marcus Cooper <codekipper@xxxxxxxxx> > >> --- > >> arch/arm/boot/dts/sun6i-a31.dtsi | 14 ++++++++++++++ > >> 1 file changed, 14 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi > >> index 7370ba6c9993..559c53efa7e6 100644 > >> --- a/arch/arm/boot/dts/sun6i-a31.dtsi > >> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > >> @@ -613,6 +613,20 @@ > >> reg = <0x01c20ca0 0x20>; > >> }; > >> > >> + spdif: spdif@01c21000 { > >> + #sound-dai-cells = <0>; > >> + compatible = "allwinner,sun6i-a31-spdif"; > >> + reg = <0x01c21000 0x400>; > >> + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; > >> + clocks = <&ccu CLK_APB1_SPDIF>, <&ccu CLK_SPDIF>; > >> + resets = <&ccu RST_APB1_SPDIF>; > >> + clock-names = "apb", "spdif"; > >> + dmas = <&dma 2>, <&dma 2>; > >> + dma-names = "rx", "tx"; > >> + spdif-out = "disabled"; > > > > That property isn't documented anywhere, and doesn't seem to be used > > in your driver either. > > Ooops....do you want me to respin a new patch or will you do your > magic with 'dd'? Sorry, it's C-w for me :) > It fell through the cracks as it was cherry picked from my dev > branch where I was at one time playing with spdif-in. This has > pretty much been relegated to the bottom of my todo/finish list. I fixed and applied. > > On a separate topic, is the channel inversion bug also found on the > > A31? > > I have seen this and I'm sure that was also on my A31 hardware but > I've just fired her up and the speaker test worked as expected. I also > repeated the test on my A10 device and didn't hear the issue. Ok. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature