Hi, On 20/12/2016 15:25, Maxime Ripard wrote: > Hi, > > On Tue, Dec 20, 2016 at 11:27:03AM +0100, Quentin Schulz wrote: [...] >> +Currently, the touchscreen controller does not have a driver using this ADC >> +driver. The touchscreen controller is currently driven only by >> +input/touchscreen/sun4i-ts.c which is absolutely incompatible with this driver. >> + >> +The Allwinner A10, A13 and A31 SoCs already have a DT binding for the >> +aforementioned input driver, thus an MFD driver matches the existing DT binding >> +(mfd/sun4i-gpadc.c) and replaces the input driver. No DT binding is required for >> +these SoCs' ADC, everything is handled by the MFD which is matching the existing >> +DT binding for input/touchscreen/sun4i-ts.c. >> + >> +The Allwinner A33 GPADC only have a thermal sensor and have a proper DT binding >> +for this driver unlike the previously mentioned SoCs. > > The DT bindings should be agnostic from the OS. You can remove all > mention of the implementations details in Linux. > > (and you should wrap at 72 characters). > > But we already have a binding document for that controller, so you > shouldn't create a new one, reuse the old one that is already there. > ACK. >> +Required properties: >> + - compatible: "allwinner,sun8i-a33-gpadc-iio" > > IIO is an implementation detail. The IP is called GPADC. > You're also missing reg. > ACK. >> + >> +Optional properties: >> +(for use with thermal framework for CPU thermal throttling for example, and/or >> + IIO consumers) >> + - #thermal-sensor-cells = <0>; (see >> +Documentation/devicetree/bindings/thermal/thermal.txt) >> + - #io-channel-cells = <0>; (see >> +Documentation/devicetree/bindings/iio/iio-bindings.txt) > > I wouldn't list that as optional. > In what sense? Do you mean you wouldn't put them here at all or you would require them? Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
