Thanks for your review! On Tue, Dec 20, 2016 at 1:03 AM, Andrew Lunn <andrew@xxxxxxx> wrote: >> > + reset { >> > + compatible = "linkstation,power-off"; >> > + reg = <0x12100 0x100>; >> > + clocks = <&core_clk 0>; >> > + }; >> >> This might be another user for UART slave device [0]. >> [0] https://lkml.org/lkml/2016/8/24/769 >> >> Is the UART port used for anything else besides the reset >> controller? > > I don't know much about these specific devices, but the qnap > equivalent, there is a user space daemon which also talks to the > microcontroller, for things like a temperature sensor, buzzer, etc. > > https://www.hellion.org.uk/qcontrol/ > > So the UART can be in a messed up state, which is why the QNAP driver, > which this code is modelled on, reset it back to a good state. For Linkstation/KuroBox-Pro, it's quite similar, and the user-land program is called micro-evtd [0], which is co-maintained by Ryan Tandy and me in Debian. [0] https://tracker.debian.org/pkg/micro-evtd >> [0] https://lkml.org/lkml/2016/8/24/769 Do I need to modify anything related to the above UART slave device? Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html