Hi Alan! On Wed, Dec 11, 2013 at 02:15:25PM -0600, delicious quinoa wrote: > On Fri, Dec 6, 2013 at 3:09 PM, Alan Tull <delicious.quinoa@xxxxxxxxx> wrote: > > From: Alan Tull <atull@xxxxxxxxxx> > > > > Hi Linus, > > > > If you don't have any further comments, can you take this patch? > > > > Alan > > Basically, this is a driver that Jamie wrote and was upstreaming a few > years ago. For some reason it never quite made it into the kernel. I > picked it up, updated the interrupt support, posted it to the list and > went through some reviews with it. > > This driver has been reviewed, I hope it can make it into the kernel. > > Alan > Sorry for chiming in late. I tested your driver on the Sockit and the GPIOs work fine (basically just tested the 4 HPS LEDS that are on this board). With the interrupt support I had a little trouble though: The Sockit has an ADXL345 on the i2c bus with a gpio as interrupt line. First: When you use "interrupt-parent", you have to specify the gpio node, rather than the gpio-bank that has the interrupt-controller property. Is that expected? I'm not really sure if that is normal behavior... Second: The interrupt is registered as "GIC 37", which is a real interrupt on the Socfpga. I would expect it to be marked as "GPIO 2xx" (or something in that range). The interrupt from the gpiochip itself isn't registered at all ?! Third: The interrupt didn't work. But that might also be my failure. I guess/hope you tested interrupts successfully?! (Fourth: small typo in the documentation example: "snps,nr-gpio" instead of "snps,nr-gpios") Regards, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
