Hello, On Mon, 2016-12-05 at 09:52 +0100, Corentin Labbe wrote: > Hello > > I have two minor comment. > > On Mon, Dec 05, 2016 at 03:01:23PM +0800, Ryder Lee wrote: > > This adds support for the MediaTek hardware accelerator on > > mt7623/mt2701/mt8521p SoC. > > > > This driver currently implement: > > - SHA1 and SHA2 family(HMAC) hash alogrithms. > > There is a typo for algorithms. > > [...] > > +/** > > + * struct mtk_desc - DMA descriptor > > + * @hdr: the descriptor control header > > + * @buf: DMA address of input buffer segment > > + * @ct: DMA address of command token that control operation flow > > + * @ct_hdr: the command token control header > > + * @tag: the user-defined field > > + * @tfm: DMA address of transform state > > + * @bound: align descriptors offset boundary > > + * > > + * Structure passed to the crypto engine to describe where source > > + * data needs to be fetched and how it needs to be processed. > > + */ > > +struct mtk_desc { > > + u32 hdr; > > + u32 buf; > > + u32 ct; > > + u32 ct_hdr; > > + u32 tag; > > + u32 tfm; > > + u32 bound[2]; > > +}; > > Do you have tested this descriptor with BE/LE kernel ? I did not test it with BE kernel, because both CPU and accelerator in our SoC just run on LE system. Thanks for reminding me, i will use byteorder conversion macros and type identifiers. > Regards > Corentin Labbe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html