Hi, On Wed, Dec 11, 2013 at 4:05 AM, Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > Hi, > > On Mon, Dec 09, 2013 at 10:43:29AM +0800, Chen-Yu Tsai wrote: >> >> @@ -2759,15 +2760,18 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device, >> >> } >> >> } >> >> >> >> + clk_disable_unprepare(priv->stmmac_clk); >> >> + >> > >> > Hu? Why do you disable the clock? don't you need it afterwards? >> >> The clock is enabled in *_open (when the network interface is used), >> and disabled in *_close. > > Maybe it is the real issue then. > > Why don't you move the clk_disable to _remove then? I wasn't sure this was the proper way. However, looking around, it seems other drivers enable the clock in, _probe, and disable it in _remove. I will modify stmmac to do so as well. ChenYu -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
