On Tue, Dec 06, 2016 at 08:09:33PM -0600, Chris Bostic wrote: > diff --git a/include/linux/fsi.h b/include/linux/fsi.h > index efa55ba..66bce48 100644 > --- a/include/linux/fsi.h > +++ b/include/linux/fsi.h > @@ -27,6 +27,12 @@ struct fsi_device { > uint32_t size; > }; > > +extern int fsi_device_read(struct fsi_device *dev, uint32_t addr, > + void *val, size_t size); > +extern int fsi_device_write(struct fsi_device *dev, uint32_t addr, > + const void *val, size_t size); > +extern int fsi_device_peek(struct fsi_device *dev, void *val); > + > struct fsi_device_id { > u8 engine_type; > u8 version; > @@ -40,7 +46,6 @@ struct fsi_device_id { > #define FSI_DEVICE_VERSIONED(t, v) \ > .engine_type = (t), .version = (v), > > - > struct fsi_driver { > struct device_driver drv; > const struct fsi_device_id *id_table; Strange whitespace change here :) Not a real problem, I like the fact that you have broken this down into very logical pieces making it much easier to review, thanks so much for doing this. greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html