On Tue, Dec 06, 2016 at 08:09:31PM -0600, Chris Bostic wrote: > From: Jeremy Kerr <jk@xxxxxxxxxx> > > Add some helpers for the crc checks for the slave configuration table. > This works 4-bits-at-a-time, using a simple table approach. > > We will need this in the FSI core code, as well as any master > implementations that need to calculate CRCs in software. > > Signed-off-by: Jeremy Kerr <jk@xxxxxxxxxx> > Signed-off-by: Chris Bostic <cbostic@xxxxxxxxxx> > --- > drivers/fsi/fsi-core.c | 21 +++++++++++++++++++++ > drivers/fsi/fsi-master.h | 21 +++++++++++++++++++++ > 2 files changed, 42 insertions(+) Why not just create lib/crc4.c with these functions, like the other crc functions in the kernel? Don't bury these in some random driver subsystem please. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html