> From: Scott Wood [mailto:oss@xxxxxxxxxxxx] > Sent: Wednesday, December 07, 2016 2:59 AM > > On Tue, Dec 06, 2016 at 03:13:38PM +0200, Madalin Bucur wrote: > > Signed-off-by: Madalin Bucur <madalin.bucur@xxxxxxx> > > --- > > arch/powerpc/boot/dts/fsl/t1024qds.dts | 29 > +++++++++++++++++++++++++++++ > > arch/powerpc/boot/dts/fsl/t1024rdb.dts | 33 > +++++++++++++++++++++++++++++++++ > > 2 files changed, 62 insertions(+) > > So, in patch 1/3 you add qman and bman nodes to t1023si-post.dtsi and > call it "add QMan and BMan portal nodes on t1023rdb" as if it were > board-specific (the only board-specific part is the reserved-memory > nodes, not the portals). > > Then, in this patch you only touch board-specific files, and label it > "add QMan and BMan portal nodes on t1024"... That needs fixing... > > diff --git a/arch/powerpc/boot/dts/fsl/t1024rdb.dts > b/arch/powerpc/boot/dts/fsl/t1024rdb.dts > > index 302cdd2..73a6453 100644 > > --- a/arch/powerpc/boot/dts/fsl/t1024rdb.dts > > +++ b/arch/powerpc/boot/dts/fsl/t1024rdb.dts > > @@ -41,6 +41,31 @@ > > #size-cells = <2>; > > interrupt-parent = <&mpic>; > > > > + aliases { > > + sg_2500_aqr105_phy4 = &sg_2500_aqr105_phy4; > > + }; > > What does this have to do with the qman and bman portal nodes? Why is > this alias needed? > > -Scott It's needed by u-boot, should be a separate patch. I'll resend. Madalin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
