On Fri, Dec 02, 2016 at 04:18:06PM +0900, Chanwoo Choi wrote: > This patch adds the bus nodes using VDD_INT for Exynos5433 SoC. > Exynos5433 has the following AMBA AXI buses to translate data > between DRAM and sub-blocks. > > Following list specify the detailed correlation between sub-block and clock: > - CLK_ACLK_G2D_{400|266} : Bus clock for G2D > - CLK_ACLK_MSCL_400 : Bus clock for MSCL (Mobile Scaler) > - CLK_ACLK_GSCL_333 : Bus clock for GSCL (General Scaler) > - CLK_SCLK_JPEG_MSCL : Bus clock for JPEG > - CLK_ACLK_MFC_400 : Bus clock for MFC (Multi Format Codec) > - CLK_ACLK_HEVC_400 : Bus clock for HEVC (High Effective Video Codec) > - CLK_ACLK_BUS0_400 : NoC(Network On Chip)'s bus clock for PERIC/PERIS/FSYS/MSCL > - CLK_ACLK_BUS1_400 : NoC's bus clock for MFC/HEVC/G3D > - CLK_ACLK_BUS2_400 : NoC's bus clock for GSCL/DISP/G2D/CAM0/CAM1/ISP > > Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi | 208 +++++++++++++++++++++++++ > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1 + > 2 files changed, 209 insertions(+) > create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi > new file mode 100644 > index 000000000000..b1e1d9c622e1 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi > @@ -0,0 +1,208 @@ > +/* > + * Samsung's Exynos5433 SoC Memory interface and AMBA bus device tree source > + * > + * Copyright (c) 2016 Samsung Electronics Co., Ltd. > + * Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > + * > + * Samsung's Exynos5433 SoC Memory interface and AMBA buses are listed > + * as device tree nodes are listed in this file. This duplicates the introduction line and does not make sense. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +/ { Shouldn't these be under soc node? It looks like property of SoC itself. > + /* INT (Internal) block using VDD_INT */ > + bus_g2d_400: bus_g2d_400 { In node name, the dash '-' is preferred. The name should describe general class of device so probably this should be just "bus"... but I don't see a way how to do it reasonable anyway. > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu_top CLK_ACLK_G2D_400>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_g2d_400_opp_table>; > + status ="disable"; Hm? > + }; > + > + bus_mscl: bus_mscl { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu_top CLK_ACLK_MSCL_400>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_g2d_400_opp_table>; > + status ="disable"; > + }; > + > + bus_jpeg: bus_jpeg { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu_top CLK_SCLK_JPEG_MSCL>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_g2d_400_opp_table>; > + status ="disable"; > + }; > + > + bus_mfc: bus_mfc { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu_top CLK_ACLK_MFC_400>; > + > + clock-names = "bus"; > + operating-points-v2 = <&bus_g2d_400_opp_table>; > + status ="disable"; > + }; > + > + bus_g2d_266: bus_g2d_266 { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu_top CLK_ACLK_G2D_266>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_g2d_266_opp_table>; > + status ="disable"; > + }; > + > + bus_gscl: bus_gscl { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu_top CLK_ACLK_GSCL_333>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_gscl_opp_table>; > + status ="disable"; > + }; > + > + bus_hevc: bus_hevc { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu_top CLK_ACLK_HEVC_400>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_hevc_opp_table>; > + status ="disable"; > + }; > + > + bus_bus0: bus_bus0 { bus, bus, bus, bus, jackpot! Let's try to find better name and label for these. :) Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html