From: Nishanth Menon <nm@xxxxxx> Date: Wed, 11 Dec 2013 12:24:38 -0600 > Hi Tony, > On 11/27/2013 12:56 PM, Tony Lindgren wrote: >> Commit 89ce376c6bdc (drivers/net: Use of_match_ptr() macro in smc91x.c) >> added minimal device tree support to smc91x, but it's not working on >> many platforms because of the lack of some key configuration bits. >> >> Fix the issue by parsing the necessary configuration like the >> smc911x driver is doing. As most smc91x users seem to use 16-bit >> access, let's default to that if no reg-io-width is specified. >> >> Cc: Nicolas Pitre <nico@xxxxxxxxxxx> >> Cc: Mark Rutland <mark.rutland@xxxxxxx> >> Cc: netdev@xxxxxxxxxxxxxxx >> Cc: devicetree@xxxxxxxxxxxxxxx >> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> >> >> --- >> >> Device tree folks, any objection to using the reg-io-width property >> as a mask here? >> >> Looks like we can use reg-io-width as a mask too if needed, it seems >> to play fine with combinations of 1 = 8-bit, 2 = 16-bit, 4 = 32-bit >> and so on. >> >> I would like to see this merged during the -rc cycle as this makes >> my test devices behave the same way when booted in legacy platform >> data mode compared to when booted with device tree. >> > please feel free to add my: > Acked-by: Nishanth Menon <nm@xxxxxx> > > Also tested on SDP2430: > http://pastebin.mozilla.org/3756403 That patch needs changes, it adds a warning when CONFIG_OF is disabled because the variable 'np' only gets used in the CONFIG_OF protected code block yet is declared unconditionally. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
