Re: [PATCH 06/11] ARM: dts: imx: Add imx6sll EVK board dts support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, Dec 2, 2016 at 4:39 AM, Bai Ping <ping.bai@xxxxxxx> wrote:
> Add basic dts support for imx6sll EVK baoard.

s/baord/board

> +       battery: max8903@0 {
> +               compatible = "fsl,max8903-charger";
> +               pinctrl-names = "default";
> +               dok_input = <&gpio4 13 1>;
> +               uok_input = <&gpio4 13 1>;
> +               chg_input = <&gpio4 15 1>;
> +               flt_input = <&gpio4 14 1>;
> +               fsl,dcm_always_high;
> +               fsl,dc_valid;
> +               fsl,adc_disable;

These properties do not exist in mainline, please remove them.


> +               status = "okay";
> +       };
> +
> +       pxp_v4l2_out {
> +               compatible = "fsl,imx6sl-pxp-v4l2";
> +               status = "okay";
> +       };

We don't have pxp support in mainline kernel, please remove it.

> +
> +       regulators {
> +               compatible = "simple-bus";
> +               #address-cells = <1>;
> +               #size-cells = <0>;


Please remove it and place the regulator nodes directly as below:


> +
> +               reg_usb_otg1_vbus: regulator@0 {
> +                       compatible = "regulator-fixed";
> +                       reg = <0>;
> +                       regulator-name = "usb_otg1_vbus";
> +                       regulator-min-microvolt = <5000000>;
> +                       regulator-max-microvolt = <5000000>;
> +                       gpio = <&gpio4 0 GPIO_ACTIVE_HIGH>;
> +                       enable-active-high;
> +               };

    reg_usb_otg1_vbus: regulator-usb-otg1-vbus {
          compatible = "regulator-fixed";
          regulator-name = "usb_otg1_vbus";
          regulator-min-microvolt = <5000000>;
          regulator-max-microvolt = <5000000>;
          gpio = <&gpio4 0 GPIO_ACTIVE_HIGH>;
          enable-active-high;
    };

> +&cpu0 {
> +       arm-supply = <&sw1a_reg>;
> +       soc-supply = <&sw1c_reg>;
> +};

This is only for LDO bypass mode, right? We don't support LDO-bypass
in mainline.

> +&gpc {
> +       fsl,ldo-bypass = <1>;

We don't support ldo-bypass in mainline, please remove it.

> +&pxp {
> +       status = "okay";
> +};

We don't support PXP in mainline, please remove it.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux