Hi Rob, Thanks for the review. On Sun, Dec 4, 2016 at 3:05 AM, Rob Herring <robh@xxxxxxxxxx> wrote: > On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: <snip> >> +Required properties: >> +- compatible: Should be "cdns,macb-mdio" > > Only one version ever? This needs more specific compatible strings. > This is part of the Cadence MAC in a way. I can use revision number from the Cadence spec I was working with. But it is not necessarily specific that version. I'll take care of the other comments in the next version. Regards, Harini -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html