Le 12/03/16 à 13:35, Rob Herring a écrit : > On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: >> Add documentations for macb mdio driver. > > Bindings document h/w, not drivers. > >> >> Signed-off-by: Harini Katakam <harinik@xxxxxxxxxx> >> --- >> .../devicetree/bindings/net/macb-mdio.txt | 31 ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/macb-mdio.txt >> >> diff --git a/Documentation/devicetree/bindings/net/macb-mdio.txt b/Documentation/devicetree/bindings/net/macb-mdio.txt >> new file mode 100644 >> index 0000000..014cedf >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/macb-mdio.txt >> @@ -0,0 +1,31 @@ >> +* Cadence MACB MDIO controller >> + >> +Required properties: >> +- compatible: Should be "cdns,macb-mdio" > > Only one version ever? This needs more specific compatible strings. > >> +- reg: Address and length of the register set of MAC to be used >> +- clock-names: Tuple listing input clock names. >> + Required elements: 'pclk', 'hclk' >> + Optional elements: 'tx_clk' >> +- clocks: Phandles to input clocks. You are also missing mandatory properties: #address-cells = <1> and #size-cells = <0> Where is patch 1? Can you make sure you have the same recipient list for both patches in this series so we can review both the binding and driver? Thanks! -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
