On Wednesday, December 11, 2013 at 05:18:45 AM, Sourav Poddar wrote: > Hi Marek, > > On Tuesday 10 December 2013 06:19 PM, Marek Vasut wrote: > > On Friday, December 06, 2013 at 03:24:41 PM, Sourav Poddar wrote: > >> The patch series aims to add memory mapped support for TI qspi > >> contoller and also add support for the same in serial flash > >> driver(m25p80). > > > > My question is, shall we not wait for the new SPI NOR framework to be > > well fleshed out and only then implement this controller driver on top > > of it ? > > I think it will still take lot of time for spi framework to come to > alignment > and get merged in the mainline. Till then, m25p80 development should > go on independently. Once, the spi framework is ready, I can myself port > this into the new framework. Sure, but I also think Huang is coming close to the new framework. Have you seen his latest patchset ( Message-ID: <1386318764-15882-1-git-send-email- b32955@xxxxxxxxxxxxx> ) ? I think you two should really start working on the new framework instead of bending drivers all around. > > I have a feeling this patchset adds quite a lot of ad-hoc hacks into the > > m25p80 driver, which would become dead code once converted to the SPI > > NOR framework. > > I dont think that spi framework till now provides capabilities which can > be used > to handle memory mapped cases. Not yet, so please bring it up in the discussion there :) > I did a quad mode support for m25p80 which easily got cloned into the > new spi framework. > Same can be done for the memory mapped support too The quad mode didn't need any new hooks in the m25p80, did it ? That's the difference here. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
