Re: [PATCH V6 08/10] PM / OPP: Allow platform specific custom set_opp() callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 30-11-16, 14:04, Stephen Boyd wrote:
> On 11/30, Viresh Kumar wrote:
> > The generic set_opp() handler isn't sufficient for platforms with
> > complex DVFS.  For example, some TI platforms have multiple regulators
> > for a CPU device. The order in which various supplies need to be
> > programmed is only known to the platform code and its best to leave it
> > to it.
> > 
> > This patch implements APIs to register platform specific set_opp()
> > callback.
> > 
> > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > Tested-by: Dave Gerlach <d-gerlach@xxxxxx>
> > 
> > ---
> 
> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

Thanks.

> So this one has the same set/put problem the other APIs has?

Yes.

> Presumably we're going to need to fix and change the API that is
> introduced here. Wouldn't it be better to do that first though?

Returning opp_table is one of the solutions and I am not sure if it is
the best one. I am working on the cleanup series and will modify all
the routine the same way very soon.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux