Hello, On Wed, 30 Nov 2016 15:00:14 +0100, Romain Perier wrote: > #ifdef CONFIG_I2C_PXA_SLAVE > dev_info(&i2c->adap.dev, "Enabling slave mode\n"); > @@ -1234,6 +1238,9 @@ static int i2c_pxa_probe(struct platform_device *dev) > i2c->reg_idbr = i2c->reg_base + pxa_reg_layout[i2c_type].idbr; > i2c->reg_icr = i2c->reg_base + pxa_reg_layout[i2c_type].icr; > i2c->reg_isr = i2c->reg_base + pxa_reg_layout[i2c_type].isr; > + i2c->fm_mask = pxa_reg_layout[i2c_type].fm ? pxa_reg_layout[i2c_type].fm : ICR_FM; > + i2c->hs_mask = pxa_reg_layout[i2c_type].hs ? pxa_reg_layout[i2c_type].hs : ICR_HS; These lines are too long according to checkpatch. What about using what Wolfram originally suggested, i.e: i2c->fm_mask = pxa_reg_layout[i2c_type].fm ?: ICR_FM; which does exactly the same, but fits within 80 characters ? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
