Hello Chanwoo, On 2016년 11월 30일 17:36, Chanwoo Choi wrote: > Dear Seung-Woo, > > I think that this patch looks good to me. > But, When I tested this patch on my TM2 board, > the flash turn off after some millisecond automatically. Thank you for testing on your side. I will check on my side about the issue, and if I find, then I will send next version. Regards, - Seung-Woo Kim > > It is strange situation. Unfortunately, I don't know the cause. > I think that we better to check this issue for more time. > > Best Regards, > Chanwoo Choi > > On 2016년 11월 30일 13:48, Seung-Woo Kim wrote: >> From: Ingi Kim <ingi2.kim@xxxxxxxxxxx> >> >> This patch adds Kinetic ktd2692 flash led device node for TM2 board. >> >> Signed-off-by: Ingi Kim <ingi2.kim@xxxxxxxxxxx> >> Signed-off-by: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> >> --- >> Change from v1: >> - gpio active value is set with defined macro instead of value. >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ >> 1 files changed, 13 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index f21bdc2..0d454aa 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -58,6 +58,19 @@ >> reg = <0x0 0x20000000 0x0 0xc0000000>; >> }; >> >> + camera-flash { >> + compatible = "kinetic,ktd2692"; >> + ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>; >> + aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>; >> + >> + flash-led { >> + label = "ktd2692-flash"; >> + led-max-microamp = <300000>; >> + flash-max-microamp = <1500000>; >> + flash-max-timeout-us = <1835000>; >> + }; >> + }; >> + >> gpio-keys { >> compatible = "gpio-keys"; >> >> > > -- Seung-Woo Kim Samsung Software R&D Center -- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html