Hello, On Tue, Nov 29, 2016 at 02:12:46PM -0800, Eric Anholt wrote: > Eduardo Valentin <edubezval@xxxxxxxxx> writes: > > > Hello Eric, Martin, > > > > On Mon, Nov 28, 2016 at 12:30:38PM -0800, Eric Anholt wrote: > >> Either the device was initialized by the firmware before handing off to > >> ARM (today's firmware) or it never will be (potential future firmware). > > > > And do you have a way to check if the firmware has the initialization > > code or not? By firmware version, for example. Or even, chip version, > > maybe? > > We would know if it's not present because the register would be in its > power-on reset state, which is what the code is checking for. This just looks odd for a driver, in its probe, to check if device is in reset state, only then initializes it. if not, it assumes everything is fine. Besides that, as described in the code, sounds like a quirk. + * right now the FW does set up the HW-block, so we are not + * touching the configuration registers. + * But if the HW is not enabled, then set it up + * using "sane" values used by the firmware right now. And based on what you are describing now, it is not a quirk, but it is by design (??) Again, does it hurt to always initialize the device to a *sane* config? BR, -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
