On Tuesday, November 29, 2016 4:04:59 PM CET Maninder Singh wrote: > This patch fixes NULL pointer dereference when pos->file is NULL. > > caught with static analysis tool. > Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx> > Signed-off-by: Vaneet Narang <v.narang@xxxxxxxxxxx> > --- > scripts/dtc/srcpos.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/scripts/dtc/srcpos.c b/scripts/dtc/srcpos.c > index f534c22..360fd14 100644 > --- a/scripts/dtc/srcpos.c > +++ b/scripts/dtc/srcpos.c > @@ -252,12 +252,11 @@ struct srcpos * > srcpos_dump(struct srcpos *pos) > { > printf("file : \"%s\"\n", > - pos->file ? (char *) pos->file : "<no file>"); > + pos->file ? pos->file->name : "<no file>"); > printf("first_line : %d\n", pos->first_line); > The patch looks right, but the description doesn't seem to match the bug. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html