On Mon, Nov 28, 2016 at 05:03:32PM -0600, Grygorii Strashko wrote: > +static int cpts_of_parse(struct cpts *cpts, struct device_node *node) > +{ > + int ret = -EINVAL; > + u32 prop; > + > + if (of_property_read_u32(node, "cpts_clock_mult", &prop)) > + goto of_error; > + cpts->cc_mult = prop; Why not set cc.mult here at the same time? > + > + if (of_property_read_u32(node, "cpts_clock_shift", &prop)) > + goto of_error; > + cpts->cc.shift = prop; > + > + return 0; > + > +of_error: > + dev_err(cpts->dev, "CPTS: Missing property in the DT.\n"); > + return ret; > +} Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html