On Mon, Nov 28, 2016 at 11:52:26AM +0100, Andreas Färber wrote: > Hi Russell, > > Am 28.11.2016 um 11:37 schrieb Russell King - ARM Linux: > > On Sun, Nov 27, 2016 at 07:51:39PM +0100, Andreas Färber wrote: > >> To more consistently reference nodes by label, add labels for sata, > >> usb2, sdhci and usb3 nodes. > >> > >> Convert all other 38x boards for consistency. Add labels for nfc and rtc. > > > > Please don't do this for clearfog - there's changes in the pipeline which > > completely replace armada-388-clearfog.dts because there's a "base" and > > "pro" versions of this hardware now, and making such a huge change will > > effectively mean we have to start over with the DT files. > > Would it help to split it back up into a series of add-labels, > use-labels like I had originally? Then you could start using them in > your refactoring as soon as the add-labels patch gets applied. Or are > you completely against this style? What I mentioned is not a case of a work in progress, it's already out in the wild, and completely changing the clearfog dts file by changing the style of DT references will make applying the changes _much_ more difficult - not only obviously impossible to apply the original patch, but also quite impossible to identify the changes made downstream. So, I'd rather armada-388-clearfog.dts is not touched at all as it _will_ cause conflicts, but I have nothing against the new style (and I actually prefer it.) What I'm asking is that you don't make other people's lives harder than they need to be. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
