On 11/18/2016 03:59 AM, Shawn Lin wrote: > Add binding document for the Rockchip serial flash controller. > > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> > Acked-by: Rob Herring <robh@xxxxxxxxxx> > --- > > Changes in v2: None > > .../devicetree/bindings/mtd/rockchip-sfc.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/rockchip-sfc.txt > > diff --git a/Documentation/devicetree/bindings/mtd/rockchip-sfc.txt b/Documentation/devicetree/bindings/mtd/rockchip-sfc.txt > new file mode 100644 > index 0000000..28430ce > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/rockchip-sfc.txt > @@ -0,0 +1,31 @@ > +Rockchip Serial Flash Controller > + > +Required properties: > +- compatible : Should be > + "rockchip,rk1108-sfc", "rockchip,sfc" for ROCKCHIP RK1108. > +- address-cells : Should be 1. > +- size-cells : Should be 0. Shouldn't these two props have a # prefix ? I'm not sure they should even be part of this binding document at all. > +- clocks: Must contain two entries for each entry in clock-names. > +- clock-names: Shall be "sfc" for the transfer-clock, and "hsfc" for > + the peripheral clock. > +- interrupts : Should contain the interrupt for the device. > +- reg: Physical base address of the controller and length of memory mapped. > + > +Optional properties: > +- rockchip,sfc-no-dma: Indicate the controller doesn't support dma transfer. DMA should be in capital letters. > +Example: > +nor_flash: sfc@301c0000 { > + compatible = "rockchip,rk1108-sfc", "rockchip,sfc"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&cru SCLK_SFC>, <&cru HCLK_SFC>; > + clock-names = "sfc", "hsfc"; > + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>; > + reg = <0x301c0000 0x1000>; > + spi-nor@0 { > + compatible = "jedec,spi-nor"; > + spi-max-frequency = <12000000>; > + reg = <0>; > + }; > +}; > -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html