On Wednesday 23 November 2016 05:37 PM, Sudeep Holla wrote: >> So, the if(!of_node_get()) is just an expensive NULL pointer check. I >> think >> it is better to be explicit about it by not using of_node_get/put() at >> all. >> How about: >> > > Are we planning to use this in any time sensitive paths? Anyways I am > fine removing them. Not worried about the time taken as much as it serving as a bad example and getting carried over to other places where the impact might actually be real. > >> +int of_machine_get_model_name(const char **model) >> +{ >> + int error; >> + >> + if (!of_root) >> + return -EINVAL; >> + >> + error = of_property_read_string(of_root, "model", model); >> + if (error) >> + error = of_property_read_string_index(of_root, >> "compatible", >> + 0, model); >> + return error; >> +} >> +EXPORT_SYMBOL(of_machine_get_model_name); >> >> I know the patch is already in -next so I guess it depends on how >> strongly >> Rob feels about this. > > Frank expressed his concerns and it may be reverted. Didn't notice that. I will check that thread. Thanks! Regards, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html