On Fri, Nov 18, 2016 at 09:33:13PM +0200, Andy Shevchenko wrote: > > @@ -1569,7 +1569,7 @@ int dw_dma_probe(struct dw_dma_chip *chip) > > (dwc_params >> DWC_PARAMS_MBLK_EN & > > 0x1) == 0; > > } else { > > dwc->block_size = pdata->block_size; > > - dwc->nollp = pdata->is_nollp; > > + dwc->nollp = pdata->multi_block[i]; > > You missed the point. You assign positive value to negative variable. > It's a bug. Have you tested this? How? > > In case of positive property you have to update DTS. By the way, I'm > pretty sure that spare13xx boards has auto configuration enabled, though > it has to be checked with vendor (I assume you may have fast response > from them). Yeah why are we not using auto configuration here would be the first question.. -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html