On Tuesday 22 November 2016 04:36 PM, Sudeep Holla wrote: > > > On 22/11/16 10:57, Bartosz Golaszewski wrote: >> 2016-11-22 11:53 GMT+01:00 Sudeep Holla <sudeep.holla@xxxxxxx>: >>> >>> >>> On 22/11/16 10:41, Bartosz Golaszewski wrote: >>>> >>>> Add a function allowing to retrieve the compatible string of the root >>>> node of the device tree. >>>> >>> >>> Rob has queued [1] and it's in -next today. You can reuse that if you >>> are planning to target this for v4.11 or just use open coding in your >>> driver for v4.10 and target this move for v4.11 to avoid cross tree >>> dependencies as I already mentioned in your previous thread. >> >> Rob's patch checks the model first - I'm not sure this is the behavior >> we want here as Sekhar suggested we print the machine compatible. > > IIUC, you are replacing of_flat_dt_get_machine_name and > of_machine_get_model_name does exactly same. So I don't see any point in > adding this new function and it's just used for logging purpose. > Also Sekhar just gave example by using just compatible adding that > function in the driver itself. > > As Arnd suggested me[1], you should for v4.10 fix it in the driver > itself to avoid the cross tree dependencies at this point similar to [2] +1. Bartosz, can you please fix it in the driver for v4.10. If there is an API available, we can move to it for v4.11 Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
