Hello Rob, >> +Example: >> + >> +fmc: fmc@1e620000 { >> + compatible = "aspeed,ast2400-fmc"; >> + reg = < 0x1e620000 0x94 >> + 0x20000000 0x02000000 >> + 0x22000000 0x02000000 >; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + flash@0 { >> + reg = < 0 >; >> + compatible = "jedec,spi-nor" ; >> + label = "bmc"; > > label isn't really a defined property here. Belongs in jedec,spi-nor > binding if you want to add it. > I am not sure I understand the suggestion. Do you mean that we should rename the device node to something like "bmc@0" to identify a flash module on the system ? This is a bit problematic for user space today as we need to sort out which flash modules are for the BMC or for the host, each having a primary and alternate. So the "label" was a practical way for identification. Thanks, C. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html