On Mon 14 Nov 11:16 PST 2016, Stephen Boyd wrote: > On 11/07, Stanimir Varbanov wrote: > > +#include <linux/module.h> > > +#include <linux/of_reserved_mem.h> > > +#include <linux/platform_device.h> > > +#include <linux/qcom_scm.h> > > +#include <linux/remoteproc.h> > > + > > +#include "qcom_mdt_loader.h" > > +#include "remoteproc_internal.h" > > + > > +#define VENUS_CRASH_REASON_SMEM 425 > > This is unused. Is there going to be some common smem API to get > the crash reason? There are a couple of these operations that are good candidates to be shared between all Qualcomm remoteproc drivers. I just haven't spent the time to figure out how to properly splice it. For the crash reason specifically, there are three operations done in the other drivers; read-and-null-terminate, then this is outputed to the log, also indicating what type of event we had. And finally the remoteproc core is informed about the crash, with a event-type passed and we get another line in the log based on that, i.e. there's room for a few improvements in this area. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
