On Fri, 2016-11-18 at 11:19 +0000, Luis Oliveira wrote: > - Add slave defintitions to i2c-designware-core > - Changes in Kconfig to auto-enable I2C_SLAVE when compiling the > modules > - Add compatible string to designware-core.txt explaining the > devicetree bindings > > --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt > @@ -2,7 +2,9 @@ > > Required properties : > > - - compatible : should be "snps,designware-i2c" > + - compatible : should be: > + - "snps,designware-i2c" to setup the hardware block as I2C master. > + - "snps,designware-i2c-slave" to setup the hardware block as I2C > slave. Not sure about this one. Compatible string is more generic than list of modes. Basically you have to add a property which selects mode. DT people's ACK is a must for this change. --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -470,6 +470,7 @@ config I2C_DESIGNWARE_CORE > config I2C_DESIGNWARE_PLATFORM > tristate "Synopsys DesignWare Platform" > select I2C_DESIGNWARE_CORE > + select I2C_SLAVE > Common rule, generic dependencies usually go first select I2C_SLAVE select I2C_DESIGNWARE_CORE -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html