On Thu, Nov 17, 2016 at 06:13:39AM +0530, Ritesh Harjani wrote: > Add xo entry to sdhc clock node on all qcom platforms. > > Signed-off-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxxx> > --- > arch/arm/boot/dts/qcom-apq8084.dtsi | 16 ++++++++++------ > arch/arm/boot/dts/qcom-msm8974.dtsi | 16 ++++++++++------ > arch/arm64/boot/dts/qcom/msm8916.dtsi | 10 ++++++---- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 9 +++++---- > 4 files changed, 31 insertions(+), 20 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi > index 39eb7a4..f756cbb 100644 > --- a/arch/arm/boot/dts/qcom-apq8084.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8084.dtsi > @@ -182,13 +182,13 @@ > }; > > clocks { > - xo_board { > + xo_board: xo_board { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <19200000>; > }; > > - sleep_clk { > + sleep_clk: sleep_clk { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <32768>; > @@ -416,8 +416,10 @@ > reg-names = "hc_mem", "core_mem"; > interrupts = <0 123 0>, <0 138 0>; > interrupt-names = "hc_irq", "pwr_irq"; > - clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; > - clock-names = "core", "iface"; > + clocks = <&gcc GCC_SDCC1_APPS_CLK>, > + <&gcc GCC_SDCC1_AHB_CLK>, > + <&xo_board 0>; With clock-cells = <0>, this should be <&xo_board> Somehow this passes the dtc compiler. But it is still incorrect. Please fix all instances of this to use the correct number of cells in the xo_board references. Andy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html