> + [REGS_A3700] = { > + .ibmr = 0x00, > + .idbr = 0x04, > + .icr = 0x08, > + .isr = 0x0c, > + .isar = 0x10, > + }, Can't you reuse REGS_PXA3XX? > static const struct platform_device_id i2c_pxa_id_table[] = { > @@ -98,6 +106,7 @@ static const struct platform_device_id i2c_pxa_id_table[] = { > { "pxa3xx-pwri2c", REGS_PXA3XX }, > { "ce4100-i2c", REGS_CE4100 }, > { "pxa910-i2c", REGS_PXA910 }, > + { "armada-3700-i2c", REGS_A3700 }, So, you declare a platform_device_id here... > + if (of_device_is_compatible(np, "marvell,armada-3700-i2c")) { > + i2c->fm_mask = ICR_BUSMODE_FM; > + i2c->hs_mask = ICR_BUSMODE_HS; > + } else { > + i2c->fm_mask = ICR_FM; > + i2c->hs_mask = ICR_HS; > + } ... but don't consider this case here?
Attachment:
signature.asc
Description: PGP signature