On 11/16/2016 05:28 PM, Adrian Hunter wrote: > On 16/11/16 10:25, Jaehoon Chung wrote: >> On 11/16/2016 05:09 PM, Adrian Hunter wrote: >>> On 16/11/16 09:53, Jaehoon Chung wrote: >>>> Added Adrian for sdhci.h >>>> >>>> On 11/15/2016 07:12 PM, Jaehoon Chung wrote: >>>>> It's not for only sdhci controller. >>>>> So it can be moved from sdhci.h to mmc.h. And renamed from sdhci_cookie >>>>> to mmc_cookie. >>> >>> The cookie is currently host private data, so I don't understand the >>> motivation behind this. >> >> dwmmc controller can also use the data->host_cookie. because it's working with post/pre_req(). >> >> So i think it can be used about both sdhci and dwmmc. >> Is there no reason that add the private dwmmc data? >> >> With these cookie value, update the dwmmc controller for post/pre_req(). >> >> https://patchwork.kernel.org/patch/9429287/ > > So why not define dwmmc cookies in dw_mmc.c ? Because I understood that it's not sdhci specific cookies. It can be used generally, doesn't? Role of post/pre_req() in host controller is the doing dma_map/unmap(). And data's cookies only needs to notice whether dma is mapped or unmapped, etc. Well, If it's really private value and should be added other cookies values in future, i will put cookies in dw_mmc.h. (it should be duplicated in sdhci and dwmmc.) Best Regards, Jaehoon Chung > > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
