On 15-11-16, 16:11, Dave Gerlach wrote: > On 11/15/2016 12:56 PM, Stephen Boyd wrote: > >On 11/15, Viresh Kumar wrote: > >>There are two important pieces of information we need for multiple > >>regulator support: > >>- Which regulator in the consumer node corresponds to which entry in > >> the OPP table. As Mark mentioned earlier, DT should be able to get > >> us this. > > > >This is also possible from C code though. Or is there some case > >where it isn't possible if we're sharing the same table with two > >devices? I'm lost on when this would ever happen. > > > >It feels like trying to keep the OPP table agnostic of the > >consuming device and the device's binding is more trouble than > >it's worth. Especially considering we have opp-shared and *-name > >now. > > I agree with this, I do not like having to pass a list of regulator names to > the opp core that I *hope* the device I am controlling has provided. What do you mean by that? Are you saying this from DT's point of view or of the code? i.e. Are you saying that you don't like the dev_pm_opp_set_regulators() API ? > The > intent seems to be to use the cpufreq-dt driver as is and not pass any I would like to kill all regulators code from cpufreq-dt sometime soon. All that is left there is making sure we have a regulator in place, but I strongly feel OPP core is the right place for doing that now. > cpu-supply anymore so the cpufreq-dt driver has no knowledge of what > regulators are present (it operates as it would today on a system with no > regulator required). But as is it will move forward regardless of whether or > not we actually intended to provide a multi regulator set up or platform > set_opp helper, and this probably isn't ideal. Yes and that's why I am more inclined towards my above comment. We shall make it consistent. > I would think cpufreq-dt/opp > core should be have knowledge of what regulators are needed to achieve these > opp transitions and make sure everything is in place before moving ahead. The last patch in my series does what you are looking for: PM / OPP: Don't assume platform doesn't have regulators Isn't it ? -- viresh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
