On 11/15/2016 08:30 AM, Andrew Lunn wrote: > On Tue, Nov 15, 2016 at 03:29:12PM +0100, Jerome Brunet wrote: >> On some platforms, energy efficient ethernet with rtl8211 devices is >> causing issue, like throughput drop or broken link. >> >> This was reported on the OdroidC2 (DWMAC + RTL8211F). While the issue root >> cause is not fully understood yet, disabling EEE advertisement prevent auto >> negotiation from enabling EEE. >> >> This patch provides options to disable 1000T and 100TX EEE advertisement >> individually for the realtek phys supporting this feature. > > Looking at the code, i don't see anything specific to RealTek > here. This all seems generic. So should it be in phy.c and made a > generic OF property which can be applied to any PHY which supports > EEE. Agreed. Just to be sure, Jerome, you did verify that with EEE no longer advertised, ethtool --set-eee fails, right? The point is that you may be able to disable EEE on boot, but if there is a way to re-enable it later on, we would want to disable that too. -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
