On 2013-12-05 19:05, Tony Lindgren wrote: > * Tomi Valkeinen <tomi.valkeinen@xxxxxx> [131204 04:31]: > > Description missing.. But other than that can you please check that > the latest patch I posted in thread "[PATCH] ARM: OMAP2+: Fix populating > the hwmod data from device" works with this? > > The test to do is to remove the related reg, interrupt and dma entries > from omap_hwmod_*_data.c, and make sure the related hwmod data is initialized > from DT properly. I made a quick test with panda, by applying your patch and reverting b38911f3472be89551bfca740adf0009562b9873. That only effectively tests the DISPC IRQ, but that worked fine. > I don't know if it makes sense to have them as children of dss_core, they > really all seem to be completely independent devices? The DSS subdevices depend on the dss_core. dss_core has to be powered up for any of the subdevices to work. This is done automatically by the runtime PM when the subdevices are children of the dss_core. > BTW, for v3.15, I'm hoping to do patches where we deprecate ti,hwmods > property and do the lookup based on the compatible property instead ;) > So from that point of view we need to get the device mapping right in > the .dtsi files, and don't want to start mixing up separate devices into > single .dtsi entry. Hmm, was that just a general comment, or something that affects the DSS DT data I have in my patch? As far as I understand, the DSS nodes reflect the current hwmods correctly. With the exception that DPI and SDI do not have a matching hwmod, as they are really part of dss_core/dispc. They are separate nodes as they are "video outputs" the same way as the other subnodes. I could perhaps remove the DPI and SDI nodes, and have them as direct video ports from DISPC, but... That's easier said than done. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
