On 06/11/2016 23:58, Boris Brezillon wrote:
> Applied after fixing a few coding style issues to make checkpatch happy.
First of all, I want to thank you for all the help you provided
along the way.
I have to admit that I'm a bit frustrated by some of the changes you made
to the patch.
Specifically, changing
from: if (ptr_expr == NULL)
to: if (!ptr_expr)
I dislike the second form, because it "hides" what is being tested.
I've even seen people use !count to mean count == 0, and I find that
very unintuitive.
I also have a hard time discerning a '!' after a '('
The other change is the chip->options initialization. I thought
you said on IRC I could keep my preferred formatting.
In the end, these are tiny issues in the grand scheme of things,
but it was important for me to point them out.
Regards.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
