On Thu, Nov 10, 2016 at 2:34 AM, Corey Minyard <minyard@xxxxxxx> wrote: > On 11/09/2016 08:42 AM, Cédric Le Goater wrote: >> The patch raises a few questions on the "BT Interface Capabilities" : >> >> - should we use sysfs or a specific ioctl to configure the driver ? > > > I should probably say sysfs, but really I don't care. The hard part about > ioctls is the compat, and there shouldn't be any compat issues with this > interface. An ioctl is probably easier, especially if you add an ioctl for > the header size thing I talked about in the previous email. > > The only thing that matters to the driver is the timeout. If you want to > make the timeout per fd, then it will have to be an ioctl. I vote for an ioctl as it's simpler for userspace. In another driver we use on the BMCs we have a character device and a few sysfs files for configuration. This means userspace needs to discover and open > 1 fd, which is annoying. Cheers, Joel >> - should the driver handle directly the response to the "Get BT >> Interface Capabilities" command ? > > > That probably belongs in userspace. The only reason I can think of > to have it in the driver would be so the host driver can fetch it if the > BMC userspace is down, but I can't see how that's a good idea. > > Hope my wishy-washy answer helps :-). -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
