On Tue, Oct 25, 2016 at 04:16:58AM -0700, Jeremy McNicoll wrote: > +static const struct qcom_cc_desc gcc_msm8994_desc = { > + .config = &gcc_msm8994_regmap_config, > + .clks = gcc_msm8994_clocks, > + .num_clks = ARRAY_SIZE(gcc_msm8994_clocks), > + .resets = NULL, > + .num_resets = 0, > + .gdscs = NULL, > + .num_gdscs = 0, > +}; > + > +static const struct of_device_id gcc_msm8994_match_table[] = { > + { .compatible = "qcom,gcc-8994" }, > + { .compatible = "qcom,gcc-8994v2" }, > + {} > +} > + > +MODULE_DEVICE_TABLE(of, gcc_msm8994_match_table); > + > +static int gcc_msm8994_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct clk *clk; > + const char *compat = NULL; > + int compatlen = 0; > + bool is_v2 = false; > + > + clk = devm_clk_register(dev, &xo.hw); > + if (IS_ERR(clk)) > + return PTR_ERR(clk); > + > + compat = of_get_property(pdev->dev.of_node, "compatible", &compatlen); > + if (!compat || (compatlen <= 0)) > + return -EINVAL; It is almost never correct to use of_get_property(). Please avoid it. > + > + is_v2 = !strcmp(compat, "qcom,gcc-8994v2"); > + if (is_v2) > + msm_gcc_8994v2_fixup(); Either put some data in the of_device_id tables, and use that to determine what to do here, or use of_device_is_compatible() or of_match_node() to check the string. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html