Resending reply due to incorrect MIME type. On Sat, Dec 7, 2013 at 5:26 AM, David Miller <davem@xxxxxxxxxxxxx> wrote: > > From: Chen-Yu Tsai <wens@xxxxxxxx> > Date: Sat, 7 Dec 2013 01:29:35 +0800 > > > @@ -47,6 +47,7 @@ static int stmmac_probe_config_dt(struct platform_device *pdev, > > plat->bus_id = 0; > > > > of_property_read_u32(np, "snps,phy-addr", &plat->phy_addr); > > + plat->force_sf_dma_mode = of_property_read_bool(np, "snps,force_sf_dma_mode"); > > Will this do the right thing for when the property is not present? > Right now the force_sf_dma_mode value is always false. of_property_read_bool will return false when the property is not present. > In fact won't it override the explicit settings done elsewhere in the > driver? Point taken. The current implementation will override settings passed from platform data. ORing the two would be better. Thanks -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
