Hi Rob and Pavel, On Sun, Oct 30, 2016 at 03:41:34PM -0500, Rob Herring wrote: > On Sun, Oct 23, 2016 at 09:17:06PM +0200, Pavel Machek wrote: > > > > Add device tree binding documentation for toshiba et8ek8 sensor. > > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@xxxxxxxxx> > > Signed-off-by: Pavel Machek <pavel@xxxxxx> > > > > --- > > > > diff from v3: explain what clock-frequency means > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > new file mode 100644 > > index 0000000..54863cf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > @@ -0,0 +1,51 @@ > > +Toshiba et8ek8 5MP sensor > > + > > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device > > + > > +More detailed documentation can be found in > > +Documentation/devicetree/bindings/media/video-interfaces.txt . > > + > > + > > +Mandatory properties > > +-------------------- > > + > > +- compatible: "toshiba,et8ek8" > > +- reg: I2C address (0x3e, or an alternative address) > > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts > > +- clocks: External clock to the sensor > > +- clock-frequency: Frequency of the external clock to the sensor. Camera > > + driver will set this frequency on the external clock. > > This is fine if the frequency is fixed (e.g. an oscillator), but you > should use the clock binding if clocks are programable. We've discussed the matter here (v3): <URL:http://www.spinics.net/lists/linux-media/msg101210.html> <URL:http://www.spinics.net/lists/linux-media/msg101233.html> Pavel, could you add to the desciption e.g.: "The clock frequency is a pre-determined frequency known to be suitable to the board." -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
