On Mon, 2016-10-31 at 00:32 -0500, Rob Herring wrote: > On Thu, Oct 27, 2016 at 09:17:34PM +0200, Gordan Markus wrote: > > This adds LM8333 devicetree parsing for the keypad part. > > Optional properties to specify the keypad driver active > > time and debounce time. > > > > Signed-off-by: Gordan Markuš <gordan.markus@xxxxxxxxx> > > --- > > .../devicetree/bindings/input/ti,lm8333.txt | 45 ++++++++++++++++++ > > It is preferred that bindings be a separate patch. Thanks Rob. Just to be clear, should I create a new thread with two patches? > > > drivers/input/keyboard/lm8333.c | 54 ++++++++++++++++++++++ > > 2 files changed, 99 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/ti,lm8333.txt > > > > diff --git a/Documentation/devicetree/bindings/input/ti,lm8333.txt b/Documentation/devicetree/bindings/input/ti,lm8333.txt > > new file mode 100644 > > index 0000000..4100d48 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/ti,lm8333.txt > > @@ -0,0 +1,45 @@ > > +LM8333 Keypad > > + > > +Required properties: > > +- compatible: Compatible property value should be "ti,lm8333". > > + > > +- reg: Physical base address of the peripheral and length of memory mapped > > + region. > > + > > +- interrupts: The interrupt number for the peripheral. > > + > > +- linux,keymap: The keymap to use > > + (see Documentation/devicetree/bindings/input/matrix-keymap.txt) > > + > > +Optional properties: > > +- ti,active-time: Specify the time during which the keypad is scanned after > > + the last key is released, before entering Halt mode. > > + The active time must be longer than the debounce time. > > + Default 500 ms. > > Add a unit suffix. The property will be renamed to "ti,active-time-ms". > > > + > > +- ti,debounce-time: Specify the keypad debounce time. > > + This can be used for reliable scanning of keyboards with noisy contacts. > > + Default 10 ms. > > Don't we have a common property for this? There isn't a common property, as far as I can tell. Different devices have different debounce time properties. Furthermore, the property should have a unit sufix as well, i.e. it should be renamed to "ti,debounce-time-ms", right? Gordan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
