On Mon, 31 Oct 2016, Noam Camus wrote: > > static unsigned long nps_timer_rate; > +static int nps_get_timer_clk(struct device_node *node, Please don't glue variables and functions together w/o a new line. That's horrible to read. > +static int __init nps_setup_clocksource(struct device_node *node) > { > int ret, cluster; > + struct clk *clk; > > for (cluster = 0; cluster < NPS_CLUSTER_NUM; cluster++) > nps_msu_reg_low_addr[cluster] = > nps_host_reg((cluster << NPS_CLUSTER_OFFSET), > NPS_MSU_BLKID, NPS_MSU_TICK_LOW); > > - ret = clk_prepare_enable(clk); > - if (ret) { > - pr_err("Couldn't enable parent clock\n"); > - return ret; > - } > - > - nps_timer_rate = clk_get_rate(clk); > + nps_get_timer_clk(node, &nps_timer_rate, clk); Why are you ignoring the return code? It was handled before your change ... Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html