> -----Original Message----- > From: Y.B. Lu > Sent: Friday, October 28, 2016 2:06 PM > To: Y.B. Lu; 'Scott Wood'; 'linux-mmc@xxxxxxxxxxxxxxx'; > 'ulf.hansson@xxxxxxxxxx'; 'Arnd Bergmann' > Cc: 'linuxppc-dev@xxxxxxxxxxxxxxxx'; 'devicetree@xxxxxxxxxxxxxxx'; > 'linux-arm-kernel@xxxxxxxxxxxxxxxxxxx'; 'linux-kernel@xxxxxxxxxxxxxxx'; > 'linux-clk@xxxxxxxxxxxxxxx'; 'linux-i2c@xxxxxxxxxxxxxxx'; > 'iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx'; 'netdev@xxxxxxxxxxxxxxx'; 'Greg > Kroah-Hartman'; 'Mark Rutland'; 'Rob Herring'; 'Russell King'; 'Jochen > Friedrich'; 'Joerg Roedel'; 'Claudiu Manoil'; 'Bhupesh Sharma'; Qiang > Zhao; 'Kumar Gala'; 'Santosh Shilimkar'; Leo Li; X.B. Xie; M.H. Lian > Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms > > > -----Original Message----- > > From: Y.B. Lu > > Sent: Friday, October 28, 2016 2:00 PM > > To: 'Scott Wood'; linux-mmc@xxxxxxxxxxxxxxx; ulf.hansson@xxxxxxxxxx; > > Arnd Bergmann > > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > > linux-arm- kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > linux- clk@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; > > iommu@lists.linux- foundation.org; netdev@xxxxxxxxxxxxxxx; Greg > > Kroah-Hartman; Mark Rutland; Rob Herring; Russell King; Jochen > > Friedrich; Joerg Roedel; Claudiu Manoil; Bhupesh Sharma; Qiang Zhao; > Kumar Gala; Santosh Shilimkar; Leo Li; X.B. > > Xie; M.H. Lian > > Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms > > > > > > > > > -----Original Message----- > > > From: linux-mmc-owner@xxxxxxxxxxxxxxx [mailto:linux-mmc- > > > owner@xxxxxxxxxxxxxxx] On Behalf Of Scott Wood > > > Sent: Friday, October 28, 2016 12:46 PM > > > To: Y.B. Lu; linux-mmc@xxxxxxxxxxxxxxx; ulf.hansson@xxxxxxxxxx; Arnd > > > Bergmann > > > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > > > linux-arm- kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > > linux- clk@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; > > > iommu@lists.linux- foundation.org; netdev@xxxxxxxxxxxxxxx; Greg > > > Kroah-Hartman; Mark Rutland; Rob Herring; Russell King; Jochen > > > Friedrich; Joerg Roedel; Claudiu Manoil; Bhupesh Sharma; Qiang Zhao; > > Kumar Gala; Santosh Shilimkar; Leo Li; X.B. > > > Xie; M.H. Lian > > > Subject: Re: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ > > > platforms > > > > > > On Fri, 2016-10-28 at 11:32 +0800, Yangbo Lu wrote: > > > > + guts->regs = of_iomap(np, 0); > > > > + if (!guts->regs) > > > > + return -ENOMEM; > > > > + > > > > + /* Register soc device */ > > > > + machine = of_flat_dt_get_machine_name(); > > > > + if (machine) > > > > + soc_dev_attr.machine = devm_kstrdup(dev, machine, > > > > GFP_KERNEL); > > > > + > > > > + svr = fsl_guts_get_svr(); > > > > + soc_die = fsl_soc_die_match(svr, fsl_soc_die); > > > > + if (soc_die) { > > > > + soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL, > > > > + "QorIQ %s", soc_die- > > > > >die); > > > > + } else { > > > > + soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL, > > > > "QorIQ"); > > > > + } > > > > + soc_dev_attr.soc_id = devm_kasprintf(dev, GFP_KERNEL, > > > > + "svr:0x%08x", svr); > > > > + soc_dev_attr.revision = devm_kasprintf(dev, GFP_KERNEL, > "%d.%d", > > > > + SVR_MAJ(svr), SVR_MIN(svr)); > > > > + > > > > + soc_dev = soc_device_register(&soc_dev_attr); > > > > + if (IS_ERR(soc_dev)) > > > > + return PTR_ERR(soc_dev); > > > > > > ioremap leaks on this error path. Use devm_ioremap_resource(). > > > > > > > [Lu Yangbo-B47093] Ok. I have fixed it in v14. Thanks :) > > [Lu Yangbo-B47093] Sorry, used the wrong error code... Will resent it [Lu Yangbo-B47093] The v15 had been sent. And dropped patch 'dt: bindings: update Freescale DCFG compatible', since that work has been done by below patch on ShawnGuo's linux tree. 'dt-bindings: fsl: add LS1043A/LS1046A/LS2080A compatible for SCFG and DCFG' https://git.kernel.org/cgit/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/dt64&id=981034a2bfcaff5c95dafde24d7abfe7f9025c19 Thanks. > > > > > > -Scott > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" > > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > > > info at http://vger.kernel.org/majordomo-info.html ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
